Add system icon source option for supported applets#60
Merged
Conversation
✅ Deploy Preview for dockingbar canceled.
|
Some applets that wrap well-known system actions (Applications, Calculator, Desktop, Screenshot, Session, Trash) can now use the system theme icon instead of the built-in Docking icon. Users choose per-applet via the right-click menu under a new "Icon" submenu (Docking Icon / System Icon). The Applet base class adds supports_system_icon, icon_source(), and set_icon_source() so opt-in applets only need to set the flag and rename create_icon to create_docking_icon. When system icon is selected and the theme provides the icon, it is used; otherwise it falls back to the built-in Docking icon.
edumucelli
force-pushed
the
system-docking-icons
branch
from
7252d12 to
28dfd62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some applets that wrap well-known system actions (Applications, Calculator, Desktop, Screenshot, Session, Trash) can now use the system theme icon instead of the built-in Docking icon. Users choose per-applet via the right-click menu under a new Icon submenu (Docking Icon / System Icon).
The Applet base class adds supports_system_icon, icon_source(), and set_icon_source() so opt-in applets only need to set the flag and rename create_icon to create_docking_icon. When system icon is selected and the theme provides the icon, it is used; otherwise it falls back to the built-in Docking icon.